Skip to content

KeybindingHint: Fix platform-aware Mod ordering - #8762

Draft
siddharthkp wants to merge 2 commits into
mainfrom
fix/keybinding-hint-mod-order
Draft

siddharthkp wants to merge 2 commits into
mainfrom
fix/keybinding-hint-mod-order

Conversation

@siddharthkp

@siddharthkp siddharthkp commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Fix KeybindingHint treating Mod as an ordinary key during sorting. Give it the same sorting priority as Meta on Apple platforms and Control elsewhere, while preserving its platform-specific display name.

For example, Shift+Mod+K now displays the Command/Control modifier before Shift. Apply the same ordering to accessible shortcut descriptions.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

  • Tests
  • VRT

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2bee236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 16, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8762 November 16, 2026 12:14 Inactive
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 16, 2026
@primer-integration

Copy link
Copy Markdown

⚠️ Integration PR Outdated

This integration PR does not have the latest commit from the primer/react PR.

Integration PR references: 2a3e0947eb8048a9c9771984c14102915d43063a
Latest commit on primer/react PR: 2bee23621c2459ed9fcd50429094526749a59fd3

Please update the integration PR to reference the latest commit from the primer/react PR before reviewing workflow results.

This branch was successfully deployed

2 active deployments
storybook-preview-8762 — 2bee2362 Deployed Nov 16, 2026 by github-actions[bot]
github-pages — 2bee2362 Deployed Nov 16, 2026 by primer[bot] via deploy-preview #34317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant