Repository navigation
fix: keep TreeView paging on visible items - #8761
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f6b442a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TreeView's PageUp/PageDown navigation currently counts descendants of collapsed tree items. This can select a hidden item as the next focus target, unlike the existing arrow-key navigation. When the scroll container is shorter than one row, the page size also becomes zero and the calculated target is undefined.
Count only items outside collapsed subtrees for both paging directions and clamp the page size to at least one row. Keep the existing page-relative movement and first/last-item clamping.
Changelog
New
Changed
@primer/react.Removed
Rollout strategy
Testing & Reviewing
npm test -- --run: 163 files passed, 3,106 tests passed, 3 skipped, 10 todo.npm run build,npm run type-check,npm run lint:fix,npm run lint:css, andnpm run format:diffpass.Prepared with AI assistance; the regressions and fix were verified locally.