Repository navigation
fix: keep nested details clicks inside the outer disclosure - #8760
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 475b87c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
useDetails({defaultOpen: true, closeOnOutsideClick: true}), clicking a button inside a nested<details>invokes the outeronClickOutsidehandler and closes the outer disclosure. The handler compares the nearest<details>with its own ref, so nested content is incorrectly classified as outside.Use DOM containment to determine whether the click is inside the controlled details element. Actual outside clicks still close it, and an outside-click callback can still prevent closing.
Changelog
New
Changed
useDetailskeeps the outer disclosure open when users interact with nested details content.@primer/react.Removed
Rollout strategy
Testing & Reviewing
onClickOutsideis called for the inner button.npm run build,npm run type-check,npm run lint:fix,npm run lint:css, andnpm run format:diffpass.Prepared with AI assistance; the regression and fix were verified locally.