Repository navigation
fix: preserve null values in useResponsiveValue - #8759
Open
nemo-crypto wants to merge 1 commit into
Open
nemo-crypto wants to merge 1 commit into
nemo-crypto wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4d9631a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
nullto the publicuseResponsiveValuehook currently throwsTypeError: Cannot convert undefined or null to objectduring rendering. Its generic API accepts non-responsive values, butisResponsiveValuetreatsnullas an object and callsObject.keys(null).For example,
useResponsiveValue(null, 'fallback')now returnsnullunchanged, consistent with the hook's handling of other non-responsive values. Add a null guard before inspecting the breakpoint keys; breakpoint selection and fallback behavior remain unchanged.Changelog
New
Changed
@primer/react.Removed
Rollout strategy
Testing & Reviewing
Object.keys(null)and pass with the guard.useResponsiveValueanduseMediatests: 12 passed in Chromium.npm test -- --runafter building: 3,095 passed, 3 skipped, 10 todo; one timeout in the existing deprecated DialogV1 testReturns focus to returnFocusRef on escape. Rerunning that suite alone passed all 9 tests.npm run buildnpm run type-checknpm run lint:fixnpm run lint:cssnpm run format:diffPrepared with AI assistance; the failure and fix were verified locally.