Repository navigation
(experiment) modernize Primer controls to match GitHub App - #8734
Draft
siddharthkp wants to merge 28 commits into
Draft
siddharthkp wants to merge 28 commits into
siddharthkp wants to merge 28 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Restore the active ButtonBase stylesheet and component to main while retaining the modern stylesheet for a future override layer. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep the original stylesheet unchanged and the full modern reference unused. Apply a small CSS Module layer for all-size spacing while preserving inline Link sizing and joined keyboard hints. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 179ca67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested a deployment
to
storybook-preview-8734
November 10, 2026 14:52
Abandoned
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested a deployment
to
storybook-preview-8734
November 10, 2026 15:01
Abandoned
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct Dialog comparison primary actions and refine switch geometry, disabled colors, and size alignment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue: draft visual-modernization experiment.
Bring GitHub App's newer visual treatment into Primer React's Button, ActionMenu, TextInput, Dialog, main-export SelectPanel, ToggleSwitch, and experimental KeybindingHint. Preserve existing state, keyboard, accessibility, and public API contracts, along with Primer icons and semantic light/dark/high-contrast palettes.
The project contract and review loop are documented in component-modernization.md.
Changelog
New
Changed
Removed
None. No replacement Kbd/KbdChord exports, deprecated SelectPanel2 migration, grouped virtualization, global shortcut-visibility behavior, or dependency installation.
Rollout strategy
Draft styling experiment; production rollout decisions are deferred until visual review. Published changes are covered by component-specific changesets.
Testing & Reviewing
Local review pages require the current reference Storybook on 6008, this repository's Storybook on 6007, and the comparison server on 6009:
All examples are vertically stacked, use equal iframe widths, and link to their source stories. Reference fixture changes remain local to the reference worktree and were not committed or pushed there.
Passing checks
npm run build && npm test -- --run: passed, 163 files / 3,109 tests; 3 skipped and 10 todo.npm run build: passed again after the final SelectPanel maximum-height and Dialog icon/focus corrections.npx --no-install vitest run --project '@primer/react' packages/react/src/SelectPanel/SelectPanel.test.tsx packages/react/src/Dialog/Dialog.test.tsx packages/react/src/ToggleSwitch/ToggleSwitch.test.tsx packages/react/src/KeybindingHint/KeybindingHint.test.tsx packages/react/src/ActionMenu/ActionMenu.test.tsx packages/react/src/Button/Button.test.tsx: passed, 5 matching files / 345 tests.npx --no-install vitest run --project '@primer/react' packages/react/src/SelectPanel/SelectPanel.test.tsx: passed after the final correction, including the explicit maximum-height regression.npx --no-install vitest run --project '@primer/react' packages/react/src/Dialog/Dialog.test.tsx: passed after the final correction.npx --no-install tsc --noEmit -p packages/react/tsconfig.json: passed.npm run lint,npm run lint:css,npm run lint:md, andnpm run format:diff: passed.STORYBOOK_URL=http://localhost:6007 npx --no-install playwright test e2e/components/{Dialog,SelectPanel,ToggleSwitch,KeybindingHint,Button,ConfirmationDialog}.test.ts --grep @avt --workers=2: passed, 8 matching KeybindingHint tests. The other selected files contain no matching@avtcases.Additional browser checks verified all 64 comparison story renders, actual light/dark/high-contrast theme changes on both sources, equal-width stacked layout, and reset restoring both switch states. Dialog popup dimensions and all 15 SelectPanel width/height pairs were measured against the running reference. Long and virtualized lists scroll the final option into view using the keyboard and commit it with Enter; modal selection commits with Save. Small Dialog close controls match the reference's 28px button / 16px icon; Escape restores the comparison trigger's focus through the existing returnFocusRef API. Narrow Dialog and SelectPanel popups remain inside a 360px viewport.
Baseline limitations
npm run type-check: fails locally in the existing generated Next.js validator atexamples/nextjs/.next/dev/types/validator.ts:51, which imports missingsrc/app/underlinenav/page.js. React package checking passes; no unrelated example/cache changes were made.scrollable-region-focusable, native-radio labels, and nested interactive elements. These reproduce in existing overflowing/virtualized and single-select-modal stories. Keyboard scrolling and selection were separately verified without forcing scrolling; rules were not disabled to produce a passing result.CONFLICTING/DIRTYagainst main. Pull-request CI, including canonical Linux visual baselines, cannot start until those conflicts are resolved. Theupdate snapshotslabel was refreshed after pushing, but no snapshot run was scheduled. No unrelated main-branch merge or conflict resolution was attempted.Intentional differences remain visible on the comparison pages: accessible opaque placeholders, Primer artwork and palettes, always-visible switch labels/indicators, existing modifier ordering, spinner-only loading, and existing modal radio/Cancel/Save semantics.