Skip to content

[WIP] Fix failing GitHub Actions job test (react-18) - #8727

Open
mattcosta7 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-react-18-job-failure
Open

mattcosta7 with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-react-18-job-failure

Conversation

Copilot AI commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

No linked issue.

Stabilizes the TreeView multi-character typeahead test, which intermittently failed in test (react-18), by enabling Vitest fake timers before rendering. This removes the test's dependency on real-time timer behavior.

Changelog

New

  • None.

Changed

  • Use fake timers in the TreeView multi-character typeahead test.

Removed

  • None.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None — test-only change; no runtime behavior or release coordination required.

Testing & Reviewing

  • CI: test (react-18) and the other required checks pass.

@changeset-bot

changeset-bot Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1e35396

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: mattcosta7 <8616962+mattcosta7@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for this test-only change to TreeView’s multi-character typeahead coverage.

No open issues 🎉

What changed in this PR

This test-only change aims to stabilize TreeView’s multi-character typeahead coverage after intermittent failures in the React 18 CI job.

Changes:

  • Enables Vitest fake timers before rendering the test, removing reliance on real-time timer behavior.
  • Leaves production code unchanged.
File Description
packages/​react/​src/​TreeView/​TreeView.test.tsx Enables fake timers in the multi-character typeahead test.

Review effort: Balanced

This branch was successfully deployed

2 active deployments
storybook-preview-8727 — 1e35396d Deployed Nov 10, 2026 by github-actions[bot]
github-pages — 1e35396d Deployed Nov 10, 2026 by Copilot via deploy-preview #34207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants