Repository navigation
ResetDigital: Update endpoint and remove native support - #4703
Open
Valentino3 wants to merge 2 commits into
Open
Valentino3 wants to merge 2 commits into
Valentino3 wants to merge 2 commits into
Conversation
Point the adapter at the ResetDigital requesters endpoint (https://adsreq.resetdigital.co/RTB). The previous host did not route to a bid server. Drop endpoint gzip compression since the endpoint rejects gzip-encoded bodies. Remove native from site and app media types since ResetDigital does not accept native demand. Bids with MType 4 now return an "Unsupported MType" error and native imps are no longer mapped to a native bid type.
Use https://ads.resetsrv.com/RTB, which resolves to the ResetDigital requesters load balancer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
https://prebid.resetdigital.co→https://ads.resetsrv.com/RTB. The previous host does not route to our bid servers; the new one points to the ResetDigital requesters load balancer.endpoint-compression: gzip. Our endpoint rejects gzip-encoded request bodies (returns 400).mtype4 now return anUnsupported MTypeerror, and native imps are no longer mapped to a native bid type.Notes
/RTBreturns 204 (no bid), and the same request gzip-encoded returns 400.Tests
ResetDigitalBidderTestandResetDigitalTestpass, checkstyle clean.mtypereturning an error; removed the native mapping tests.