Repository navigation
Conversation
This was referenced Nov 9, 2026
The exchange authenticates a request with its first imp token, so imps that share a partner code but carry different tokens now go out as separate requests. Bidder debug is disabled because the token travels in imp.ext.bidder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Sellwild runs an OpenRTB 2.6 exchange that partners call server-to-server. Today partners reach it through a
genericalias; this adapter replaces that with a named bidder. It supports banner, video and native for app and site requests. The matching PBS-Go adapter is prebid/prebid-server#5095.Params:
partnerCode^[A-Za-z0-9_-]{1,64}$token🧠 Rationale behind the change
This adapter isn't a
genericalias because it doesn't just forward the ORTB:https://exchange.sellwild.com/exchange/openrtb2/{PublisherId}), and the exchange authenticates a request with its first imp's token. So imps are split into one outbound request per partner code and token, in first-seen order. Each outbound request contains only its own imps.bid.mtypeis set. So in a split request a bid can't be attributed to another partner code's imp. A bid for an imp outside its request returnsbadServerResponse.bid.mtypeonly when the underlying demand did. Withoutmtype, the type comes from the matching imp if that imp declares exactly one of banner, video or native. Otherwise the bid returnsbadServerResponse. Unsupportedmtypevalues also returnbadServerResponse.imp.extis forwarded unchanged. The exchange authenticates the partner from the token inimp.ext.bidder, so the token goes only to Sellwild. Bidderdebug.allowisfalse, so the outbound body (and the token) isn't echoed in debug output.partnerCodeortokenreturnbadInputand are skipped. Valid imps in the same request still go out.ExtImpSellwild.partnerCodecarries@JsonProperty("partnerCode")because the default mapper is snake_case. The partner code is expanded throughUri.replaceMacro, which percent-encodes it, soHttpUtil.encodeUrlisn't applied as well.🔎 New Bid Adapter Checklist
support@sellwild.com; send a test message any time)🧪 Test plan
SellwildBidderTest(20 tests) covers:a b/c?d→a%20b%2Fc%3Fd);x-openrtb-version: 2.6, andimp.extforwarded unchanged;mtype, themtypefallback for single- and multi-format imps, and unsupportedmtype;mtypeset for another split request's imp, which is rejected.SellwildTestintegration test: an auction against the stubbed endpoint returns the expected response.mvn checkstyle:checkpasses.mvn testpasses: 8956 tests, 0 failures. I ran it before the bid-to-request matching and the token split were added. After those changes I re-ran checkstyle,SellwildBidderTestandSellwildTest, all passing.maven:3.9-eclipse-temurin-25), which is the version master targets.Maintainer contact:
support@sellwild.com. Reviewers can get a test partner code and token there to make live requests; without them the endpoint returns 401.Docs: prebid/prebid.github.io#6951.
🏎 Quality check
SellwildBidder: 99.0% of instructions, 98.8% of lines)🤖 Generated with Claude Code