Repository navigation
Conversation
CTMBNara
requested changes
Nov 11, 2026
Comment on lines
+54
to
+55
| import static org.apache.commons.collections4.MapUtils.emptyIfNull; | ||
| import static org.apache.commons.collections4.MapUtils.invertMap; |
|
|
||
| private boolean validateUserKey(ServerRequest request) { | ||
| final String userKey = ObjectUtils.firstNonNull(request.headers().firstHeader(USER_KEY_PARAM), | ||
| request.queryParams().getFirst(USER_KEY_PARAM)); |
Collaborator
There was a problem hiding this comment.
final String userKey = ObjectUtils.firstNonNull(
request.headers().firstHeader(USER_KEY_PARAM),
request.queryParams().getFirst(USER_KEY_PARAM));
Comment on lines
+191
to
+195
| if (StringUtils.isEmpty(userKey)) { | ||
| return false; | ||
| } | ||
|
|
||
| final String user = userKeys.get(userKey); |
Collaborator
There was a problem hiding this comment.
What about this?
final String user = StringUtils.isNotEmpty(userKey) ? userKeys.get(userKey) : null;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a support for optional pre-shared user keys which can be used to authorize external users to save the data into the Prebid Cache when external writes are secured.
The configuration syntax is this:
The user name is expected to be meaningful because it's used for metrics.