Repository navigation
Conversation
- Cache the generation switch, the per-type configuration rows and the enabled itemtypes for the request, cleared when a configuration is saved, added or removed - The counter and its reset date are still read from the database for each generated number
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Each generated number read the plugin configuration again: 9 queries per asset. The generation switch, the per-type rows and the enabled itemtypes are now read once per request. The cache is cleared when a configuration is saved, added or removed. The counter and its reset date are still read from the database for each number.
Benchmark
GLPI 11.0, 2 000 computers, generation on for computers.
This is a small gain: most of the time is GLPI updating each asset.
Tests
A new test changes the template and the generation switch between two generations in the same process. It checks that each change is seen and that the numbers stay consecutive.