Repository navigation
[main] Fix form submission error when a multiple dropdown field question is empty - #1341
Draft
glpi-project[bot] wants to merge 1 commit into
Draft
glpi-project[bot] wants to merge 1 commit into
glpi-project[bot] wants to merge 1 commit into
Conversation
Author
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin forward-port/1323-to-main
git worktree add --checkout .worktree/forward-port/1323-to-main forward-port/1323-to-main
cd .worktree/forward-port/1323-to-main
git reset --hard HEAD^
git cherry-pick -x be73dd95407fecfd7ec13fb7d0217473a03bf91c |
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #1323 to
main.Checklist before requesting a review
Please delete options that are not relevant.
Description
Submitting a form with an empty multiple dropdown field question failed with a
TypeError. An empty selection sendsitems_id = '', andformatRawAnswer()passed that value togetById()without casting it to an integer. The ids are now cast to integers and empty values are filtered out.Screenshots (if appropriate):