Repository navigation
Conversation
MySQL reorders the keys of the JSON destination config: compare the saved configs with their keys sorted.
Lainow
force-pushed
the
fix-email-folow-up-by-actor
branch
from
October 29, 2026 14:23
3c42fb9 to
9e8c39d
Compare
Lainow
requested review from
a team,
Herafia and
RomainLvr
and removed request for
a team
November 2, 2026 08:14
Herafia
requested changes
Nov 3, 2026
Herafia
previously approved these changes
Nov 4, 2026
MyvTsv
reviewed
Nov 6, 2026
RomainLvr
reviewed
Nov 9, 2026
RomainLvr
left a comment
Contributor
There was a problem hiding this comment.
Looks solid overall: the migrated form lookup (uuid5), name-based destination matching, HasFieldWithQuestionId on roles, _from_import, and the delegation handling all check out against core. A few remarks:
muteActorsInInputrelies on a core internal. CoreITILActorField::addActorToInput()appends_notifentries without the template lines, whileCommonITILObjectpairs actors and_notifby the same key. With a template, core is already misaligned. The plugin re-indexes on$line, which fixes this, but only when it mutes someone ($has_changes). So the behavior depends on whether an actor is muted. The real fix belongs in core (index_notiflike the actors); worth a separate core PR.- Duplicated logic.
getSources()andgetPersons()repeat the sameSPECIFIC_VALUES/SPECIFIC_ANSWERS/ strategy-level branching. Resolving persons from the sources already computed would remove about 80 lines from a 735-line file. - DOM hack in the Twig template. Moving the
?helper into the core label via:scope > div > label.form-labelwill break silently if the core markup changes. Acceptable without an extension point, but an E2E assertion on the helper would catch it. - Command storage in
glpi_configs. It adds onedestination_<id>row per imported destination. Fine for a one-shot command, and uninstall cleans the context, but keep it in mind for instances with thousands of destinations. - Minor:
getPersons()callsstrategy->getITILActors()again after the core actor field already did, so it runs twice per submission. Negligible today.
None of these are blocking; 1 and 2 are the ones I'd address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
Brings back the Formcreator "email followup" per actor, lost by the forms migration.
plugins:advancedforms:import-formcreator-actors-notificationcommand to import the Formcreator settings (--dry-run,--force). Imported destinations are skipped by the next runs, so manual changes are kept.Screenshots (if appropriate):