Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Cartesian axis lines that disappear when traces use different
zordervalues.Fixes #7363.
Synthetic z-order subplots share the axis paths of their primary subplot. Their axis-line pass replaces those paths with
M0,0. Skip that duplicate pass with the existingzindexSeparatorconstant.The Cartesian regression tests cover scatter and bar traces, negative and positive zorders, zorder changes, line visibility, mirrored axes, layer changes, and resize.
Minimal reproduction:
Validation on Windows, Node 24.18.0, Chromium 141:
npm run test-jasmine -- cartesian --nowatch --browsers ChromeHeadless --report-dotsfails only the two new regressionsnpm run test-jasmine -- cartesian bar scatter --nowatch --browsers ChromeHeadless --report-dotspasses all 255 testsnpm run lint,npm run typecheck, andnpm run schema-typegen-diff-checkpassnpm run test-jasmine -- cartesian axes bar scatter --nowatch --browsers ChromeHeadless --report-dotspasses 655 of 657 tests. The twoinsiderangefailures also occur on unchanged upstream sourcenpm run test-syntaxfails withExpected 7 window.getComputedStyle calls, found 0. The same failure occurs on unchanged upstream sourceThe two existing axes failures are
Test axes insiderange relayout can relayout insiderangeandmore react tests insiderange react to new data.Full image and export suites did not run. The before/after plots confirm visible axis lines after the fix.
Before:
After: