Repository navigation
fix: infer execute row types from the requested row mode - #228
Open
peterolkhov wants to merge 1 commit into
Open
peterolkhov wants to merge 1 commit into
peterolkhov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExecuteOptionsmaps object mode to the array overload and array mode to the object overload. This flips the inferred rows onClient,Connection, andTransaction, including empty and cast-only options. This change corrects the shared mapping and adds a compiler check tonpm test. Runtime behavior and explicit custom row types stay the same.Tested locally on Node 22.16.0 and 24.22.1:
npm run lint -- --fix,npm run build, andnpm testpassed. The compiler fixture checks 24 row types across all three APIs; it fails on the original mapping. All 42 runtime tests pass on both versions.Prepared with OpenAI Codex assistance.