Repository navigation
chore(rsplot): bump egui/egui-wgpu to 0.36 (wgpu 30), MSRV 1.95 - #7
Merged
Merged
Conversation
wgpu 30 wraps VertexState buffers in Option and makes get_mapped_range fallible; egui renames Panel::show_inside to show and egui_kittest::create_render_state takes RendererOptions. epaint 0.36 panics when an unapplied TexturesDelta is dropped, so the headless widget tests run through test_util::HeadlessRun, which clears the delta before the output drops.
rustc 1.98 clippy adds chunks_exact_to_as_chunks (MSRV-gated on as_chunks, stable since 1.88), so -D warnings fails on every constant-size chunks_exact at the old MSRV too. Runtime-sized calls (elem_size, rows) are not flagged and stay.
silx dialogs are QFormLayouts; plain rows can't align a label column or stretch a field against trailing buttons. widget::form gives label/fill/group in one egui pass (no retained state, no egui_flex dep) and the colormap/print/limits dialogs now use them.
Every item mutation (add_curve, remove, set_item_z, set_item_visible, update_curve, clear_items) re-cloned all visible CurveData and rebuilt every GpuCurve, so N sequential mutations rebuilt the scene N times. WgpuBackend now only marks scene_dirty; flush_scene syncs once from Plot1D::show_inner and save_graph. Unchanged z/visibility writes no longer dirty the scene.
U+22EF (midline ellipsis) is missing from egui's bundled UI font and from common fallbacks (Noto Sans Regular included), so the overflow menu button rendered as the tofu box; U+2026 is covered.
The ROI descriptions and style selector and the image-compare toolbar use arrows and box-drawing glyphs egui's default fonts lack; hosts must append a broad-coverage fallback font or those labels render as tofu.
A title or axis label longer than the plot's gutter run was drawn at full length and hit the widget clip rect mid-glyph on a narrow plot. Title, x, y, y2 and extra-axis labels now lay out single-line with U+2026 truncation bounded by the run around their center.
The adaptive density targets labels per inch but never measures label extent, so a small plot's two-tick minimum can still collide. Skip the text of any label whose span overlaps the last kept one (X, Y, y2 and extra-Y gutters); tick marks are never culled.
draw_roi anchored the Rect/HRange/VRange label above the rect's top edge, which for a VRange is the data area's top edge: the label landed in the title gutter, over the plot title. The anchor is now clamped to ROI_LABEL_INSET below the area top.
The wgpu backend stored only the data background and dropped the first argument, so a caller switching a plot to a light canvas over a dark host panel got dark (foreground-override) tick labels on the still-dark gutters. Plot gains `background`; PlotView paints the whole widget rect with it under the data layer when set, and leaves the panel fill showing through when it is not.
rust-zstd 0.1.0 was the only 0.1 release and is yanked, so a fresh resolve of the workspace (CI, any crates.io user) fails on rsdm's optional blosc ZSTD dependency; only the untracked Cargo.lock kept it building here. 0.4 keeps the compress(data, level) / decompress(data) signatures the codec calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The egui re-export makes the bump semver-breaking, so the branch also carries the 0.6.0 release commit (changelog, version bumps); the crates.io publish follows the merge. The deferred GPU sync, gutter-label eliding and culling, and the form helpers came out of the xafsview port against this branch.