Repository navigation
Bump epics-rs to 0.24.0 - #5
Merged
Merged
Conversation
From 0.22.x. Scoped to rsdm's ca/pva/calc features; rsplot and adl2rsdm carry no EPICS dependency. Three breaking API changes in 0.24 were adapted at source: - epics-ca-rs dropped `ConnectionEvent::Unresponsive`: an unresponsive circuit now surfaces as `Disconnected` (the client keeps the distinction only internally, to pick its recovery path). The two arms already did the same thing in the ca_plugin connection loop, so this collapses to `Disconnected`. - epics-pva-rs `pvrpc` now returns `RpcReply` (an enum) instead of a `(FieldDesc, PvField)` tuple, with an `Empty` variant for pvxs's no-value `ExecOp::reply()`. The plugin reads the value via `RpcReply::into_value`; `Empty` maps to the existing "connected, no scalar sample" branch. - epics-base-rs `EnumInfo` became `#[non_exhaustive]` (gained `string_form`); a ca_plugin test builds it with `EnumInfo::new`, which fills both slots from one label list — correct for its two-state enum. Verified with the full workspace on --all-features: fmt, clippy -D warnings, nextest (2349 workspace + 432 rsdm incl. in-process CaServer/PvaServer round-trips), and doctests all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the EPICS backends
epics-ca-rs/epics-base-rs/epics-pva-rsfrom 0.22.x to 0.24.0. Scoped to
rsdm'sca/pva/calcfeatures;rsplotandadl2rsdmcarry no EPICS dependency.0.24 has three breaking API changes, adapted at source:
ConnectionEvent::Unresponsiveremoved. 0.24 folds the echo-timeout intoDisconnected— an unresponsive circuit disconnects every consumer, and thedistinction now survives only inside the client's
ChannelState(to selectthe recovery path). The ca_plugin loop already handled both arms identically,
so it collapses to
Disconnected.pvrpcreturnsRpcReplyinstead of a(FieldDesc, PvField)tuple. Thenew enum has an
Emptyvariant for pvxs's no-valueExecOp::reply(). Theplugin reads the value through
RpcReply::into_value, mappingEmptyto theexisting "connected, no scalar sample" branch.
EnumInfobecame#[non_exhaustive](it gained astring_form). Aca_plugin test constructs it with
EnumInfo::new, which fills both slots fromone label list — correct for its two-state enum.
No release; version stays at 0.5.4 and the bump is recorded under
## [Unreleased]in the CHANGELOG.Verification
Full workspace on
--all-features:cargo fmt --all --check,cargo clippy --workspace --all-targets --all-features -- -D warnings,cargo nextest run --workspace --all-features(2349 workspace tests + 432 rsdm tests, includingthe in-process CaServer/PvaServer round-trips that exercise the changed APIs)
and
cargo test --doc --workspace --all-featuresall pass.