Repository navigation
Printer: indent a new tag like the other tags - #329
Merged
Merged
Conversation
ondrejmirtes
force-pushed
the
new-tag-indentation
branch
2 times, most recently
from
October 26, 2026 19:34
368effa to
71d6613
Compare
When the printer added a child to a PHPDoc, it used the largest indentation after the asterisk in the PHPDoc. The next lines of a multi-line description often have a larger indentation, so the new tag got it too. Now the printer uses the indentation of the line where the last existing child starts. Amp-Thread-ID: https://ampcode.com/threads/T-01a17930-0285-73c5-a957-4325c77aa1b2
ondrejmirtes
force-pushed
the
new-tag-indentation
branch
from
October 26, 2026 20:15
71d6613 to
b18e158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
printFormatPreserving()adds a child to a PHPDoc, it uses the largest indentation after*in the PHPDoc. The next lines of a multi-line description often have a larger indentation, so the new tag gets it too:Now the printer uses the indentation of the line where the last existing child starts:
If no child starts on its own line, e.g.
/** @var int $x */, the printer uses the old logic.