Repository navigation
Create shared footer logic so the whole site can share footer with release pages - #2044
mattstauffer wants to merge 1 commit into
Conversation
|
📊 Regression report for commit c9df34b is at https://web-php-regression-report-pr-2044.preview.thephp.foundation |
|
🚀 Preview for commit c9df34b is available at https://web-php-pr-2044.preview.thephp.foundation |
derickr
left a comment
derickr
left a comment
There was a problem hiding this comment.
I'm OK with this, besides the question about the style-sheet name (only a problem if the php86 release pages uses a different style file.
| // The fancy footer is the default for classic pages (see footer.inc); load its | ||
| // standalone stylesheet everywhere except the release landing pages, which ship | ||
| // their own footer styles in php85.css. | ||
| if (!in_array('php85.css', $css_files, true) && !in_array('/styles/php85.css', $css_files, true)) { |
There was a problem hiding this comment.
Are the 8.6 release pages going to use the same php85.css file, or a php86.css file @saundefined ?
|
I now see that that uses @saundefined and @sy-records, if you're both also OK with this PR, please feel free to rebase and merge. |
|
@derickr Thanks for the review! yah, I thought we may want to do a global rename of that style file, but didn't want to push that into this conversation if it would confuse it, especially when I think we have an open 8.6 release branch |
We have a lovely, robust footer on the release pages but the rest of the site gets a very sparse old footer. This PR gives the rest of the site the robust footer.
The dark purple of the more modern release page style didn't look great with the classic style, so I had it update to the grey of the classic style, and also updated it to match the width of the classic pages.
Before:
After:
