Repository navigation
[PHP-8.5] Backports for OpenSSL 4.1 - #25139
Closed
thesamesam wants to merge 2 commits into
Closed
thesamesam wants to merge 2 commits into
thesamesam wants to merge 2 commits into
Conversation
Member
|
@LamentXU123 You might be interested in this since you did the fixes for newer branches. |
thesamesam
force-pushed
the
PHP-8.5-openssl-4
branch
from
November 1, 2026 23:22
89b0c78 to
d1b5325
Compare
Member
|
CI failure is related. |
Contributor
Author
|
Yeah, I'll handle it tomorrow. |
thesamesam
marked this pull request as draft
November 2, 2026 06:30
thesamesam
force-pushed
the
PHP-8.5-openssl-4
branch
from
November 3, 2026 03:02
d1b5325 to
5fa335c
Compare
thesamesam
force-pushed
the
PHP-8.5-openssl-4
branch
from
November 3, 2026 03:04
5fa335c to
b4d01f9
Compare
thesamesam
marked this pull request as ready for review
November 3, 2026 03:13
* Fix OpenSSL 4 test compatibility * Fix OpenSSL 4 build compatibility * Use OpenSSL 4 in macOS CI * Fix OpenSSL 1.1 build compatibility * Preserve raw CN matching with OpenSSL 4 (cherry picked from commit 6aca6e3)
OpenSSL 4.1 deprecates ASN1_STRING_set() and ASN1_STRING_length(). use ASN1_STRING_set1_data() and ASN1_STRING_get_length() instead as recommended in official doc https://docs.openssl.org/4.1/man7/ossl-guide-migration/#asn1_string-values-have-never-been-nul-byte-terminated (cherry picked from commit 3678f39)
thesamesam
force-pushed
the
PHP-8.5-openssl-4
branch
from
November 3, 2026 03:56
b4d01f9 to
700949d
Compare
Member
|
Can you also move this test to 8.4 and 8.5? |
Member
|
Okay never mind I will do it in merging. Thank you! |
LamentXU123
added a commit
that referenced
this pull request
Nov 3, 2026
* PHP-8.5: Merge branch 'PHP-8.4' into PHP-8.5 ext/openssl: Restore OpenSSL 4.x compatibility on PHP 8.5 (#25139)
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the testsuite but I haven't done any further testing for it. Please give the
php_openssl_matches_common_namechanges in the first commit a careful look. The rest applied pretty cleanly from PHP-8.6.