Repository navigation
Add Kick adapter, skip HLS og:video iframes, fix Twitch video and clip embeds - #585
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kick.com)og:videono longer becomes an<iframe>Confirmed failures, before / after
https://kick.com/xqccode: null<iframe src="https://player.kick.com/xqc">640x360.player.kick.com/<slug>returns 200 with no X-Frame-Options / CSPhttps://kick.com/xqc/videos/4aeefefc-cd67-413e-8107-14327b21f5a3title: null, no image (page has no og metas)xQcand 720p thumbnail from/api/v1/video/<uuid>and/api/v2/channels/<slug>/videoshttps://kick.com/xqc/clips/clip_01M5YVZS3AF6NPDY1RMFXKRSWK<iframe src=".../playlist.m3u8">(og:video is HLS,og:video:type=application/x-mpegURL)code: nulltwitch:parentplayer.twitch.tv/?id=<ID>player.twitch.tv/?video=v<ID>&parent=...as in the Twitch docshttps://clips.twitch.tv/<slug>,twitch.tv/<channel>/clip/<slug>clips.twitch.tv/embed?clip=<slug>&parent=...whentwitch:parentis set,nullotherwise (parentis required)Detectors/Code.phpreadsog:video:typeonly for the HLS check. Using it generally changed the existing viddler fixture from iframe to video, soog:video_typestays the source for the rest.Not confirmed
player.kick.comis an SPA that returns 200 for any path, so no URL could be verified and none is emitted.Tests
tests/VideoAdaptersCodeTest.php(unit, recorded responses) and Kick / Twitch clip cases inPagesTest. No existing fixture changed. A Kick playback token in a cached HTML response is redacted.