Repository navigation
fix: resolve executable-named CLI scopes implicitly without argv rewriting - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CliApplication::run($argv)uses$argv[0]only as help text. An executable namedshillerregistering#[CliScope('shiller')]previously required synthetic invocationrun(['shiller', 'shiller', ...])to invokeshiller init, and had to special-case another scopeedit.Change
CliApplication::run().T_CommandSet, dispatch an unresolved top-level action through a scope named like the executable, without mutating or rewriting the caller's arguments. Explicit top-level groups still take precedence.tool tool initcalls.tool init, independenttool edit createandtool edit resolve, help behavior, and unrelated scopes.$app->run($argv)usage.No Shiller-specific names, commands, or special cases are introduced.
Downstream:
leuffen/leuffen-shiller-libPR #29 will remove its manual argv rewriting once this library change is available ondev-main.