Repository navigation
fix(Felt): realign docs @patternfly alias pins with workspace versions - #12705
Merged
gabipodolnikova merged 1 commit intoNov 2, 2026
Merged
gabipodolnikova merged 1 commit into
gabipodolnikova merged 1 commit into
Conversation
The release commit that bumped react-core, react-table, and react-code-editor to 0.0.1-prerelease.4 left the @patternfly/* npm aliases in react-docs pinning 0.0.1-prerelease.3. The version mismatch stops yarn from linking those aliases to the workspaces, so the committed lockfile no longer satisfies yarn install --immutable (YN0028) and every CI job fails at setup, which also blocks the release deploy job. Bump the three alias pins to 0.0.1-prerelease.4 so they link to the workspaces again. The remaining aliases (icons, styles, tokens) still match their workspace versions. These pins must be bumped in lockstep with future releases of the aliased packages until the Felt-compatible documentation framework removes the need for the aliases.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
gabipodolnikova
added a commit
that referenced
this pull request
Nov 2, 2026
…otocol (#12706) Replace the exact-version pins on the six @patternfly/* npm aliases in react-docs with workspace ranges: "@patternfly/react-core": "npm:@rh-felt/react-core@workspace:^" The exact pins had to match the workspace versions for yarn to link the aliases to the local packages, so every release of an aliased package silently broke `yarn install --immutable` (YN0028) until the pins were bumped in lockstep (#12705). The `npm:<name>@workspace:^` form binds each alias to the local workspace regardless of its current version, so releases no longer require pin bumps. The @patternfly/patternfly -> @rh-felt/styles alias keeps its registry pin because styles is not a workspace in this repo; a stale pin there only lags the published CSS package and cannot break installs. Verified: yarn install --immutable passes; a simulated version bump to an unpublished 0.0.1-prerelease.5 keeps every alias linked to its workspace with no manifest changes; yarn build and yarn build:docs pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixes the failing felt-v1 Release workflow (run 41410237436), where every job fails at the setup step.
Additional issues: Follow-up to #12699 (PF-4694)
What happened
After #12699 merged, all jobs on
felt-v1fail in ~20s atSet up project:Root cause: the release commit (
48515fc1c) bumped thereact-core,react-table, andreact-code-editorworkspaces to0.0.1-prerelease.4, but the@patternfly/*npm aliases inreact-docs(kept for@patternfly/documentation-framework, which resolves the PatternFly names internally) still pin0.0.1-prerelease.3. The squash merge combined both states, so yarn can no longer link those three aliases to the workspaces — it needs registry fallbacks instead, meaning the committed lockfile no longer matches the manifests andyarn install --immutable(what the setup action runs) fails.This also blocks the
Deploy releasejob, which is why0.0.1-prerelease.4is not on npm yet.The fix
Bump the three stale alias pins in
packages/react-docs/package.jsonto0.0.1-prerelease.4so they match the workspace versions and link to the local packages again. The remaining aliases (react-icons@0.0.1-prerelease.2,react-styles@0.0.1-prerelease.3,react-tokens@0.0.1-prerelease.2) still match their workspace versions. (I also tried aliasing via theworkspace:protocol so the pins would track the workspaces automatically — yarn 4 doesn't support that form,Workspace not found.)Note
These alias pins must be bumped in lockstep with releases of the aliased packages until the Felt-compatible documentation framework removes the need for the aliases (PF-4694 follow-up).
Verification
yarn install --immutablepasses cleanly on this branch (the exact failing CI invocation)node_modules/@patternfly/{react-core,react-table,react-code-editor}are workspace symlinks againversion: 0.0.0-use.local)