Repository navigation
fix(CI): use America/New_York instead of EST for unit tests - #12700
Merged
rebeccaalpert merged 1 commit intoOct 30, 2026
Merged
Conversation
Since Oct 29 the Unit tests job fails 3 timezone-dependent Timestamp tests on every PR. The root test script runs jest with TZ=EST, and GitHub's ubuntu-latest image migrated from ubuntu-24.04 to ubuntu-26.04 between the last passing run (Oct 27) and the first failure (Oct 29); on the newer image TZ=EST no longer applies the UTC-5 offset and jest runs as UTC instead. EST is a legacy POSIX-style abbreviation rather than an IANA zone. America/New_York is identical to EST (UTC-5, standard time) for every date used in the Timestamp tests (all in January/February), so no expected values change. Full suite passes: 396 suites, 3902 tests, 914 snapshots.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
rebeccaalpert
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Fixes the 3 failing
Timestampunit tests that have been breaking the Unit tests job on every PR since Oct 29 (no issue filed).Additional issues: none
What happened
Since Oct 29 the Unit tests job fails with 3 timezone-dependent failures in
packages/react-core/src/components/Timestamp/__tests__/Timestamp.test.tsx, e.g.:The root
testscript runs jest withTZ=EST. Between the last passing run (Oct 27) and the first failing run (Oct 29), GitHub'subuntu-latestimage migrated fromubuntu-24.04(20261012.334.1) toubuntu-26.04(20261025.179.1) — same Node version. On the newer image,TZ=ESTno longer applies the expected UTC−5 offset; jest runs as UTC instead (reproducible locally:TZ=UTCproduces exactly these 3 failures,TZ=ESTpasses).ESTis a legacy POSIX-style abbreviation rather than a real IANA zone, so depending on it is fragile.The fix
Replace
TZ=ESTwithTZ=America/New_Yorkin the roottestscript. It is identical to EST (UTC−5, standard time) for every date used in the Timestamp tests — all of them fall in January/February — so no expected values change:TZ=America/New_York yarn jest packages/react-core/src/components/Timestamp→ 26 passed, 1 skippedyarn testpasses locally with the changeVerification
yarn test(full suite) on this branch