Repository navigation
chore(Felt): switch React and docs dependencies to @rh-felt packages - #12699
Open
gabipodolnikova wants to merge 3 commits into
Open
gabipodolnikova wants to merge 3 commits into
gabipodolnikova wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
rebeccaalpert
force-pushed
the
PF-4694-felt-dependencies
branch
from
October 30, 2026 15:51
22ec2b3 to
8492965
Compare
Member
|
I am just rebasing after dependency upgrade - should fix Snyk issue that was causing PR to fail. |
Replaces the temporary PatternFly dependencies held over for the docs framework with their published @rh-felt counterparts now that @rh-felt/styles is released: - Swap @patternfly/patternfly@6.7.0-prerelease.3 for @rh-felt/styles@0.0.1-prerelease.3 in the react-core, react-icons, react-styles, react-tokens, react-docs, and demo-app manifests, the style/token/class-map/icon generation scripts, the docs CSS entry, charts examples, and the demo app - Depend on @rh-felt/styles directly in react-docs and keep @patternfly/* npm aliases to the @rh-felt prereleases solely for the documentation framework, which still resolves PatternFly package names internally; the pinned versions match the workspaces so they link to the local packages - Drop the @patternfly react-charts, react-drag-drop, and react-templates dependencies that nothing resolves - Preapprove the @rh-felt/* scope from the npm minimal age gate so freshly published prereleases can be installed - Track @rh-felt/styles instead of @patternfly/patternfly in scripts/promote.sh
demo-app-ts' manifest change makes Snyk re-test that project, and the pinned react-router 7.13.0 carries 11 direct Snyk advisories (1 critical, 5 high; highest fix floor 7.18.2), failing the security/snyk check. 7.18.4 clears all of them. 7.18.5 is the latest 7.x but is quarantined by the one-week npmMinimalAgeGate on felt-v1 (published Oct 27), so the range uses ^7.18.4 (published Sep 15). Mirrors the react-router bump in patternfly#12697 (FELT-190).
Mirrors the FELT-190 changes from patternfly#12697 so this branch carries the same Snyk remediations: - react-charts: lodash ^4.17.23 -> ^4.18.1, dropping the last 4.17.23 resolution and clearing the high-severity lodash advisories - demo app: use the pf-v6-theme-dark class, give the theme toggle radios a shared name, rename the deprecated modal demo entry, add hasNoPadding to the clipboard copy action button, give the resizable drawer demo a fixed height, check drilldown menu heights against undefined, and remove hardcoded dark inline styles from the nav demos
rebeccaalpert
force-pushed
the
PF-4694-felt-dependencies
branch
from
October 30, 2026 15:57
8492965 to
06575fb
Compare
rebeccaalpert
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Replaces the temporary PatternFly dependencies with their published
@rh-feltcounterparts, for PF-4694 / #12666.Additional issues: none
Implementation
@patternfly/patternfly@6.7.0-prerelease.3for@rh-felt/styles@0.0.1-prerelease.3in the react-core, react-icons, react-styles, react-tokens, react-docs, and demo-app manifests, the style/token/class-map/icon generation scripts, the docs CSS entry, the charts examples, and the demo app.react-docsnow depends on@rh-felt/stylesdirectly. The remaining@patternfly/*entries are npm aliases kept solely for@patternfly/documentation-framework, which still resolves PatternFly package names internally; the pinned versions match the workspaces, so yarn links the aliases to the local packages.@patternfly/react-charts,react-drag-drop, andreact-templatesdependencies that nothing resolves.@rh-felt/*scope from the npm minimal age gate (npmPreapprovedPackages) so freshly published prereleases (such as@rh-felt/styles@0.0.1-prerelease.3) can be installed.@rh-felt/stylesinstead of@patternfly/patternflyinscripts/promote.sh.Notes
@patternfly/*names inreact-docs/package.jsonare compatibility scaffolding until the Felt-compatible documentation framework ships; they can be removed in that follow-up (PF-4694).0.0.1-prerelease.xversions don't satisfy the framework's^6.7.0peer ranges — expected and non-fatal, matching the Core repo's setup.Verification
yarn install,yarn build,yarn build:docsyarn jest packages/react-tokenspf-v6class system and fonts, 254 pages in the sitemap.