Repository navigation
Conversation
pierreneter
reviewed
Nov 18, 2026
pierreneter
left a comment
Member
There was a problem hiding this comment.
Thanks for the notes and the test. The main part does not work yet, though. Line numbers are at 02037fc.
src/react/styles.css:399and the eight other duplicate declarations (400, 484, 932-935, 957, 996, 1044, 1205, 1268): eachcolor-mix()wraps avar(). A declaration that containsvar()is always valid at parse time, so it wins over the fallback before it. In a browser withoutcolor-mix()it then becomes invalid at computed-value time, and the property goes to its initial value, not back to the earlier declaration. The result is the same as before the PR: no range background, no cell selection, no hover. Checked in Chromium with an unknown function standing in forcolor-mix(): transparent / none. Only--de-src-sel, which is inside@supports, works. That is the shape to use everywhere: the plain fallback outside, the mixed declaration inside@supports (color: color-mix(in srgb, red, blue)).test/theme.test.ts:52asserts the textual pattern that does not work, and it fails on the structure that does (a mixed rule inside@supportswith its fallback outside). Also, line 47 only matches a token whose value starts withcolor-mix(, so a shadow token such as0 2px 8px color-mix(...)passes, and line 57 skips declarations that follow a comment or span two lines.docs/development.md:83says thecolor-mix()declarations have fallbacks for selection, hover and connection states. Today that holds for--de-src-selonly.docs/development.md:73: the "pending compatibility notes" are no longer pending.Theme = ThemeMode | ThemeOptions,FileMenuItem.icon: IconNameandICON_NAMESshipped in v0.14.0 (the tag contains8ba9fa0and1a670f2), so "carry these into the next release" would put them under the wrong version.
Non-blocking:
- Once the fallbacks do apply, some values are far from the mixed ones:
.de-collab-live .de-collab-dotgets a solid 3px ring where the mix is an 18% halo,.de-hf-zone:hovergets 12% / 18% where the mix is 5%, and the--de-accent-softfallbacks are the default blue even when a host setsaccent. docs/theming.md:28: the trust note covers token values, but names are passed through as well ('--de-' + kebab(k)). A key from untrusted JSON such asx:1;position:fixed;inset:0;--yends up as extra declarations in the server-renderedstyleattribute. Filtering keys byTHEME_TOKENSinthemeStyle()closes that, which is better than documenting it.- A test that pins the whole
ICON_NAMESlist would enforce the stability promise;test/icons.test.tsxchecks seven names. docs/theming.md:93still says the built-in values are the.de-rootand.de-root.de-darkblocks, while the effectivesrcSelnow lives in the@supportsblock.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add token-based fallbacks before
color-mix()declarations so selection, hover, and connection states remain visible when that function is unsupported. Mixed source-selection custom properties are gated with@supports, preserving light/dark accent mixing and hostsrcSeloverrides.Also hoist the typed icon-map example, document trusted theme configuration including SSR, and add pending migration notes for
ThemeMode,FileMenuItem.icon, and stableICON_NAMESkeys. Existing versioned release notes are unchanged.Follows up on the non-blocking review comments in #4 and #5. Fallback colors approximate the mixed states; this does not establish general support for older browsers.
Validation with Bun 1.4.4: frozen install, 15 theme/icon unit tests, typecheck, CSS build/output comparison, and diff whitespace check passed. No browser tests were added or run.