Skip to content

🌱 align Bingo tool versions with go.mod - #3085

Merged
openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:build/align-bingo-tools-with-go-mod
Oct 29, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
operator-framework:mainfrom
tmshort:build/align-bingo-tools-with-go-mod

Conversation

@tmshort

@tmshort tmshort commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Description

Align the Bingo pins for tools already listed in go.mod with the versions selected by the root module:

Tool Module Old Bingo version New version
crd-diff sigs.k8s.io/crdify v0.6.0 v0.6.1-0.20260602124154-bb9957dbf465
helm helm.sh/helm/v3 v3.18.4 v3.22.0
opm github.com/operator-framework/operator-registry v1.60.0 v1.74.0

mockgen already matches go.mod at v0.6.0. Bingo regenerated the module checksums and binary variables. This is the version-alignment step before migrating these tools to go tool in a follow-up change.

Validation

  • make verify-bingo
  • go mod verify for the three updated Bingo modules
  • git diff --check

Summary by CodeRabbit

  • Chores
    • Updated project tooling, including Helm, opm, and CRD comparison utilities.
    • Updated related build configuration and extended the verification wait window.
    • These updates affect project maintenance and do not change end-user features or behavior.

@netlify

netlify Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 792080f
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6ae3b649146477879fd84220
😎 Deploy Preview https://deploy-preview-3085--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The pinned versions of crd-diff, Helm, and opm are updated. Their module requirements and executable paths change. The Helm and opm module Go versions are updated, the opm toolchain directive is removed, and the verify-bingo timeout increases from 15 to 20.

Changes: Tool version pins

Layer / File(s) Summary
Update tool versions
.bingo/*, Makefile
The crd-diff, Helm, and opm module requirements and executable configuration use updated versions. The Helm and opm module Go versions change, and the opm toolchain directive is removed. The verify-bingo timeout increases from 15 to 20.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested labels: dependencies, go

Suggested reviewers: grokspawn

Merge Risk: Minimal · up to 79208

The tool-version alignment can be merged with no identified functional, compatibility, or operational risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the main change: aligning Bingo tool versions with go.mod. It is concise, specific, and uses the required seedling prefix.
Description check Passed The description explains the version changes, motivation, affected tools, and validation performed. The Reviewer Checklist from the template is omitted, but the description is otherwise complete and d…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the version changes, motivation, affected tools, and validation performed. The Reviewer Checklist from the template is omitted, but the description is otherwise complete and directly related to the changes.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2026
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort force-pushed the build/align-bingo-tools-with-go-mod branch from c65a657 to 792080f Compare October 29, 2026 21:10
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2026
@tmshort

tmshort commented Oct 29, 2026 •

Copy link
Copy Markdown
Member Author

Bumped the bingo timeout to 20 minutes, the newer versions were taking longer? The timeout won't matter once the utilities are moved to go tool
(But the timeout change probably wasn't necessary... )

@tmshort

tmshort commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2026

@rashmigottipati rashmigottipati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2026
@openshift-ci

openshift-ci Bot commented Oct 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4fd7cf5 into operator-framework:main Oct 29, 2026
41 of 42 checks passed
@tmshort
tmshort deleted the build/align-bingo-tools-with-go-mod branch October 29, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants