Repository navigation
test(sdk): DSPX-1561 run the shared assertion conformance vectors - #439
Draft
dmihalcik-virtru wants to merge 1 commit into
Draft
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
Vendor xtest/vectors/assertions-phase0.json from opentdf/tests (the DSPX-5520 shared vectors) byte for byte, and run every vector: assertion hashing and Section 3 parsing, manifest-level parsing, binding forms, and Section 8 verification with a selected key. Required vectors must pass; proposed ones are logged. The assertion vectors also run through the manifest reader, spliced into a TDF. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
xtest/vectors/assertions-phase0.jsonfrom opentdf/tests (the DSPX-5520 shared vectors) byte for byte assdk/src/test/resources/assertion-vectors-phase0.json.AssertionVectorsTestruns every vector: assertion hashing and Section 3 parsing, manifest-level parsing, binding forms, and Section 8 verification with a selected key. Required vectors must pass; proposed ones are logged. The assertion vectors also run through the manifest reader, spliced into a TDF. The test also checks that the SDK's modelled-names table equals the one in the file.Stacked on: #438. The vectors come from opentdf/tests#705, which should land first.
Split out of #432 (draft; the complete change). Cross-SDK counterparts: opentdf/platform#4308, opentdf/web-sdk#1142.
Checklist
Testing Instructions
mvn -pl sdk -am test -Dtest=AssertionVectorsTest -Dsurefire.failIfNoSpecifiedTests=false, or the fullmvn -pl sdk,cmdline -am test.