Skip to content

fix(sdk): DSPX-1561 align TDF manifest parsing and assertion verification across SDKs - #432

Draft
dmihalcik-virtru wants to merge 6 commits into
mainfrom
DSPX-1561-go-sdk-pluggable-assertion-validation-and-trust-an
Draft

dmihalcik-virtru wants to merge 6 commits into
mainfrom
DSPX-1561-go-sdk-pluggable-assertion-validation-and-trust-an

docs(sdk,cmdline): DSPX-1561 describe which assertions a default veri…

fbae3bb
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 9, 2026 in 40s

Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 163 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbd&open=AaHAimW4rCzGHH81wRbd&pullRequest=432

Check warning on line 218 in sdk/src/test/java/io/opentdf/platform/sdk/StrictManifestParsingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimQ9rCzGHH81wRbT&open=AaHAimQ9rCzGHH81wRbT&pullRequest=432

Check warning on line 1711 in sdk/src/test/java/io/opentdf/platform/sdk/TDFTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimUGrCzGHH81wRbV&open=AaHAimUGrCzGHH81wRbV&pullRequest=432

Check warning on line 427 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbh&open=AaHAimW4rCzGHH81wRbh&pullRequest=432

Check warning on line 244 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRb1&open=AaHAimePrCzGHH81wRb1&pullRequest=432

Check warning on line 1183 in sdk/src/main/java/io/opentdf/platform/sdk/Manifest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'com.nimbusds.jose.JOSEException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimeKrCzGHH81wRbt&open=AaHAimeKrCzGHH81wRbt&pullRequest=432

Check warning on line 106 in sdk/src/test/java/io/opentdf/platform/sdk/AssertionVerifierTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimUQrCzGHH81wRbW&open=AaHAimUQrCzGHH81wRbW&pullRequest=432

Check failure on line 421 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this access on a collection that will throw an 'ArrayIndexOutOfBoundsException' when executed.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRb7&open=AaHAimePrCzGHH81wRb7&pullRequest=432

Check warning on line 197 in sdk/src/test/java/io/opentdf/platform/sdk/AssertionVerifierTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimUQrCzGHH81wRbZ&open=AaHAimUQrCzGHH81wRbZ&pullRequest=432

Check warning on line 1183 in sdk/src/main/java/io/opentdf/platform/sdk/Manifest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.security.cert.CertificateException', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimeKrCzGHH81wRbu&open=AaHAimeKrCzGHH81wRbu&pullRequest=432

Check warning on line 677 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code to remove this label and the need for it.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbl&open=AaHAimW4rCzGHH81wRbl&pullRequest=432

Check warning on line 640 in sdk/src/main/java/io/opentdf/platform/sdk/SDK.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code in order to not assign to this loop counter from within the loop body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimbxrCzGHH81wRbn&open=AaHAimbxrCzGHH81wRbn&pullRequest=432

Check failure on line 61 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "encryptionInformation" 3 times.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRby&open=AaHAimePrCzGHH81wRby&pullRequest=432

Check warning on line 442 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRb5&open=AaHAimePrCzGHH81wRb5&pullRequest=432

Check failure on line 284 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this access that will throw a NullPointerException when executed.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRb8&open=AaHAimePrCzGHH81wRb8&pullRequest=432

Check failure on line 1058 in sdk/src/main/java/io/opentdf/platform/sdk/Manifest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "statement" 4 times.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimeKrCzGHH81wRbp&open=AaHAimeKrCzGHH81wRbp&pullRequest=432

Check failure on line 376 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "the JWS " 4 times.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbc&open=AaHAimW4rCzGHH81wRbc&pullRequest=432

Check warning on line 412 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty array instead of null.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbf&open=AaHAimW4rCzGHH81wRbf&pullRequest=432

Check warning on line 440 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Return an empty array instead of null.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbj&open=AaHAimW4rCzGHH81wRbj&pullRequest=432

Check warning on line 213 in sdk/src/test/java/io/opentdf/platform/sdk/StrictManifestParsingTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimQ9rCzGHH81wRbS&open=AaHAimQ9rCzGHH81wRbS&pullRequest=432

Check warning on line 219 in sdk/src/test/java/io/opentdf/platform/sdk/AssertionVerifierTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this lambda with method reference 'JsonParser::parseString'.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimUQrCzGHH81wRbb&open=AaHAimUQrCzGHH81wRbb&pullRequest=432

Check warning on line 936 in sdk/src/main/java/io/opentdf/platform/sdk/Manifest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "transient" modifier from this field.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimeKrCzGHH81wRbq&open=AaHAimeKrCzGHH81wRbq&pullRequest=432

Check warning on line 141 in sdk/src/test/java/io/opentdf/platform/sdk/AssertionVerifierTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.lang.Exception', as it cannot be thrown from method's body.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimUQrCzGHH81wRbX&open=AaHAimUQrCzGHH81wRbX&pullRequest=432

Check failure on line 63 in sdk/src/main/java/io/opentdf/platform/sdk/StrictJsonReader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "method" 3 times.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimePrCzGHH81wRb0&open=AaHAimePrCzGHH81wRb0&pullRequest=432

Check failure on line 510 in sdk/src/main/java/io/opentdf/platform/sdk/AssertionVerifier.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=opentdf_java-sdk&issues=AaHAimW4rCzGHH81wRbk&open=AaHAimW4rCzGHH81wRbk&pullRequest=432