Repository navigation
fix(sdk): DSPX-4748 remove the unsupported unencrypted-payload read path - #431
Draft
dmihalcik-virtru wants to merge 1 commit into
Draft
dmihalcik-virtru wants to merge 1 commit into
dmihalcik-virtru wants to merge 1 commit into
Conversation
loadTDF now rejects a manifest whose payload.isEncrypted is not true (false, null or absent) with MalformedTDFException, immediately after the manifest is parsed and before any key access, integrity or assertion processing. Segments and the root signature are always checked with the payload key, segments are always decrypted, and the segment-hash aggregate is always built from base64-decoded hashes. The writer continues to set isEncrypted to true. Signed-off-by: Dave Mihalcik <dmihalcik@virtru.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenTDF writers always produce TDFs with an encrypted payload, and reading a manifest that declares otherwise was never a supported feature. This removes that read path from the Java reader.
loadTDFrejects a manifest whosepayload.isEncryptedis nottrue(false, null, or absent) withSDK.MalformedTDFException, immediately after the manifest is parsed.Segments.aggregate, are removed.isEncryptedtotrue.Testing
mvn -B -o -pl cmdline -am package -Dmaven.antrun.skip=true: sdk 442 tests (9 skipped), sdk-pqc-bc 54, cmdline 16, all passing.TDFUnencryptedPayloadTest: TDFs declaringisEncryptedas false, null, or absent are rejected as malformed, and an unmodified TDF still loads.