Repository navigation
Conversation
Replace the architecture-repo based OLM deployment with a local,
self-contained component so that the openstack-operator Subscription
is unpinned and tracks the cluster's own catalog.
Motivation: the previous approach pulled
openstack-k8s-operators/architecture's olm-openstack-subscriptions
overlay, whose replacements hard-require the olm-values ConfigMap keys
provided by example/openstack-operator/catalog (values) and pin-version
(openstack-operator-version). Simply dropping pin-version therefore
breaks kustomize ("fieldPath data.openstack-operator-version is
missing"), and dropping the catalog resource breaks it even earlier
("nothing selected by ... data.openstack-operator-image"). There is no
way to consume that overlay unpinned.
Changes:
- Add components/dependencies/openstack-operator: a plain Component
shipping the openstack-operators/openstack Namespaces, the
OperatorGroup and the openstack-operator Subscription. The
Subscription has no spec.startingCSV (unpinned: OLM resolves the
latest CSV in the stable-v1.0 channel) and references the built-in
redhat-operators CatalogSource instead of pinning a
redhat-operator-index image to a specific OCP version, so the
catalog always matches the cluster. Its README documents the
subscribed-cluster/disconnected-mirror requirement and how to patch
or overlay the component (e.g. to pin a startingCSV).
- Slim example/openstack-operator down to the new local component plus
utilities/approve-installplan; no remote component fetch remains.
- Drop example/openstack-operator/catalog and pin-version, which only
existed to feed the architecture overlay's replacements.
The rhoso-gitops validated pattern's override patches (OperatorGroup
and shared Namespace removal, InstallPlan approval Job relocation)
still apply: resource kinds and names are unchanged.
Validated locally with kustomize build, both standalone and with the
pattern's kustomize patches applied.
Assisted-by: pi coding agent (model rits/zai-org/glm-5-3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the architecture-repo based OLM deployment with a local, self-contained component so that the openstack-operator Subscription is unpinned and tracks the cluster's own catalog.
Motivation: the previous approach pulled
openstack-k8s-operators/architecture's olm-openstack-subscriptions overlay, whose replacements hard-require the olm-values ConfigMap keys provided by example/openstack-operator/catalog (values) and pin-version (openstack-operator-version). Simply dropping pin-version therefore breaks kustomize ("fieldPath data.openstack-operator-version is missing"), and dropping the catalog resource breaks it even earlier ("nothing selected by ... data.openstack-operator-image"). There is no way to consume that overlay unpinned.
Changes:
The rhoso-gitops validated pattern's override patches (OperatorGroup and shared Namespace removal, InstallPlan approval Job relocation) still apply: resource kinds and names are unchanged.
Validated locally with kustomize build, both standalone and with the pattern's kustomize patches applied.
Assisted-by: pi coding agent (model rits/zai-org/glm-5-3)