Repository navigation
Conversation
…E_ID and set in Xcode, Project.xcconfig, Info.plist, CMake and Android on every update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated cmdLine from 0.121.0 to 0.122.0 and PG GUI from 0.116.0 to 0.117.0
A bundle id changed in
Project.xcconfig(or the Xcode target) was reset tocc.openFrameworks.<name>on every update, since the PG rewrites both from the template.APP_BUNDLE_ID = com.example.myAppconfig.makeAPP_BUNDLE_ID, thenCMakeLists.txt, the Xcode target settings,Project.xcconfig,ofApp/build.gradleapplicationId; the templates' own ids (cc.openFrameworks.${TARGET_NAME},com.openFrameworks.emptyExample,cc.openframeworks.<name>) don't count. So an existing project with a customProject.xcconfigid keeps it from its first update with this PGconfig.make(created for ios / tvos, like PROJECT_FRAMEWORKS), PRODUCT_BUNDLE_IDENTIFIER on every Xcode app target configuration (like MARKETING_VERSION),Project.xcconfig, a literalCFBundleIdentifierin a custom Info.plist ($(PRODUCT_BUNDLE_IDENTIFIER)is left alone), CMakeset(APP_BUNDLE_ID ...), AndroidapplicationId(-->_, Android doesn't allow it)--bundle-id=com.example.myApp: letters, digits,-and dots, at least two parts; a bad value warns and keeps the project'sscripts/test_cmdline_args.sh): none by default, set + kept on update, bad value, custom Project.xcconfig id kept (Xcode)make / CMake read APP_BUNDLE_ID: openframeworks/openFrameworks#8636
Tested on macOS: osx project, edit Project.xcconfig to a custom id, plain update -> kept in config.make / xcconfig / both targets, Xcode
-showBuildSettingsresolves it for Debug and Release;--bundle-idoverrides, bad value kept; literal plist id replaced; CMakeLists gets oneset(APP_BUNDLE_ID)beforeof_add_app; ios new project; androidapplicationId "com.example.my_app"kept on update; GUI import fills the field, Update writes the edited id,bad idshows the tooltip. Argument tests osx 38 / linux64 37 / vs 33, 0 failures (11 failures on the current master build).