Repository navigation
config.make PROJECT_SYSTEM_LIBS (-l), PROJECT_FRAMEWORKS Apple only, read by CMake too - #8632
Merged
Merged
Conversation
…read by CMake too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project-level system frameworks and libraries, kept in the project's
config.makeso the projectGenerator, make and CMake all use the same list (PG side: openframeworks/projectGenerator#690).PROJECT_SYSTEM_LIBS->-lsqlite3 -lz;PROJECT_FRAMEWORKS(already there) now only on Darwin, so a shared config.make doesn't pass-frameworkto Linux buildsof_add_appreads both from config.make like it reads addons.make (-frameworkon Apple only)Tested on macOS: CMake app using sqlite3 / zlib / SecRandomCopyBytes builds and runs with
-framework Security -lsqlite3 -lzfrom config.make; make flag logic checked for Darwin (-framework Security ... -lsqlite3 -lz) and Linux (-lsqlite3 -lzonly).