Skip to content

openff-3.0.0-rc1 - #164

Merged
j-wags merged 7 commits into
mainfrom
openff-3-0-0-rc1
Nov 5, 2026
Merged

j-wags merged 7 commits into
mainfrom
openff-3-0-0-rc1

Conversation

@j-wags

@j-wags j-wags commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

This PR adds openff-3.0.0.offxml (and the unconstrained variant), created by removing the ion parameters from 3.0.0-alpha2b (since they're carried over from the Sage line, which uses ion parameters fit for TIP3P) and replacing them with ion parameters from opc3.offxml (just for the same ions as Sage covered, even though more are available in that file). It also adds the water model and constraints from opc3.offxml.

  • New files added
  • Xe parameter re-added (manually added in 2.1.1)
  • Zenodo authors are reordered to put Chapin first and Gilson last.
  • README updated for new FF

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ee065ef) to head (480256c).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@j-wags j-wags self-assigned this Nov 3, 2026
@j-wags
j-wags requested a review from chapincavender November 3, 2026 00:39
@j-wags
j-wags marked this pull request as ready for review November 3, 2026 00:39

@chapincavender chapincavender left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on Xe parameters! Changes look good to me.

I tested the rc1 offxml on some protein systems in water boxes with Na+ and Cl- ions. Here's the total potential energies in kcal/mol using OpenMM's CUDA Platform with mixed precision.

System | no_water-3.0.0-alpha2b | 3.0.0-rc1
---------------------------------------------------
ala3       -6403.45440349           -6403.45438971
gly3       -6548.29213676           -6548.29210399
val3       -6187.65754456           -6187.65754935
gb3       -32857.87253555          -32857.87258022
bpti      -47662.91126517          -47662.59997210
ubq       -63929.90035637          -63929.90024801
hewl      -72161.56658396          -72161.19853259
aaqaa3   -122297.21133338         -122297.21134815

Everything matches to single precision except for a 0.4 kcal/mol discrepancy in the HarmonicAngleForce for BPTI due to the arginine angle error in #144. Since we already decided that we won't patch this bug in the 3.0.0 release, I think this is good to go.

@j-wags

j-wags commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

Per some discussion today, we're going to reduce the ions in this file to just the ones that were already present in Sage, though we'll switch them to parameters from opc3.offxml.

@j-wags
j-wags merged commit 1a4063b into main Nov 5, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants