Repository navigation
Take core 7.8.0, and ask for the Network permission when it is off - #757
Merged
Merged
Conversation
Core 7.8.0 shows page headers and footers, numbers headings and lists as LibreOffice does, and draws gradient, hatch and picture fills, slide backgrounds, shadows and Fontwork. Slides stop showing their master's placeholders. It also reports a refused socket as its own error. GrapheneOS refuses one to an app without the Network permission, and the app then showed a broken-file dialog that asked users to contact support. It now explains the permission and opens the app's settings. The next document binds the server again, so no restart is needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FW6WZa4gznT3PuKW91WKQP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Core 7.8.0 shows page headers and footers, numbers headings and lists as LibreOffice does, and draws gradient, hatch and picture fills, slide backgrounds, shadows and Fontwork. Slides stop showing master placeholders.
Core now throws
ServerSocketDenied(code 53) when the system refuses the app any socket, as GrapheneOS does without the Network permission. Until now that ended in the broken-file dialog. Now the app explains the permission and offers the app's settings. The server binds again on the next document, so no restart is needed.Tested: unit tests, lint and
CoreTest(22/22) on an emulator. A build withINTERNETremoved shows the new dialog when it opens a document.