Repository navigation
Workshop of contribution for node - #67139
Open
EstebannSa wants to merge 2 commits into
Open
EstebannSa wants to merge 2 commits into
EstebannSa wants to merge 2 commits into
Conversation
Signed-off-by: Esteban <salasesteban0228@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
Ethan-Arrowood
added
the
code-and-learn
Contributor
|
Good work @EstebannSa ! A couple things before we can merge this PR. Let me know if you need my help with any step. I also recommend looking at other PRs from the event to see how others accomplished things (for example #67125 is very similar to yours).
If you need any help just let me know! Thanks for coming to the Node.js Code and Learn at JSConfMX! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.