Repository navigation
Conversation
Signed-off-by: Brad Anderson <brad@sankatygroup.com>
Member
|
please propose any applicable changes in nodejs/node first |
Author
|
@panva The applicable behavioral fixes are now proposed in nodejs/node#67039. This PR adds a standalone CMake/pkg-config build profile. Should its shared-source guards and warning cleanups go through Node first, with only the standalone build integration proposed here afterward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default-off
NCRYPTO_EVP_ONLYprofile for OpenSSL 3.6+ consumers that build with deprecated declarations treated as errors.The profile excludes ENGINE declarations and implementation, propagates
NCRYPTO_EVP_ONLY=1through CMake and pkg-config, and avoids the existing deprecated-declaration and unused-parameter warning suppressions. Unsupported backends/versions are rejected. Default backend selection remains unchanged.Small source cleanups handle unused parameters and check the X509 parser's BIO rewind so all three translation units and an independent public-header consumer compile under strict warnings. The profile does not change prime-check behavior or include the separate provider serialization fixes.
Validation at
61b5c38832237e8c2a1c3c5531daeb5cdbf0b16fon macOS:NCRYPTO_EVP_ONLY=OFFandON: 29/29 tests pass in each mode.0.20260508.0, default profile: 25/25 tests pass.-std=c++20 -DNCRYPTO_EVP_ONLY=1 -Wall -Wextra -Werror -Wdeprecated-declarations.git diff --check.This PR is independent of the separate provider behavioral-fixes proposal.