Repository navigation
Conversation
Signed-off-by: Brad Anderson <brad@sankatygroup.com>
Member
|
please propose any applicable changes in nodejs/node first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three provider-backed behaviors:
BignumPointer::isPrime(nchecks)requests above the minimum performed by a singleBN_check_prime()call. Repeat checks as needed and preserve callback cancellation/error propagation.Regression tests cover RSA/EC PEM and DER round trips; binary, empty, missing, and incorrect passphrases; explicit EC SPKI re-export; and prime-check requests of 65/129 rounds plus callback cancellation.
Validation at
a0616695e92f9889b8d2fd35f635eb00e1ca4e8b: OpenSSL 3.6.2 on macOS, CMake Release build withNCRYPTO_SHARED_LIBS=ONandNCRYPTO_TESTING=ON, followed byctest --output-on-failure: 34/34 pass. Changed C++ files pass clang-format andgit diff --check.This PR is independent of the separate EVP-only build-profile proposal.