Repository navigation
Conversation
Replace `tinyglobby` and `glob-parent` with a small `#utils/glob.mjs` built on Node.js's `fs.globSync`, stable since 22.17 and 24.0 (doc-kit targets Node.js 24, per `.nvmrc`). It returns the same POSIX, cwd-relative paths as tinyglobby, including for absolute patterns, and leaves out directories. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1180 +/- ##
==========================================
+ Coverage 93.44% 93.47% +0.02%
==========================================
Files 278 280 +2
Lines 27820 27947 +127
Branches 2790 2811 +21
==========================================
+ Hits 25997 26124 +127
Misses 1801 1801
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| File | Main | PR | Change |
|---|---|---|---|
orama-db.json |
29.24 MB | 29.24 MB | +98.00 B (+0.0%) |
Performance estimate (single CI run)
- Generation time: 4.6% faster (7.35 s → 7.01 s)
- Peak memory: 5.2% lower (1.28 GB → 1.21 GB)
web Generator
Performance estimate (single CI run)
- Generation time: 10.4% slower (22.42 s → 24.76 s)
- Peak memory: 2.2% higher (1.90 GB → 1.94 GB)
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
avivkeller
reviewed
Oct 26, 2026
`fs.globSync` reads backslashes as path separators, never as escapes, on every platform, so `doc\api\*.md` finds `doc/api`'s files, but `globParent` only split on `/` and returned `.` for it. glob-parent converted backslashes on Windows, so this matches it again. Also covers `?` (glob syntax, which glob-parent missed) and `(b|c)` (matched literally by `fs.globSync`, which glob-parent treated as glob). Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
avivkeller
approved these changes
Oct 27, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
tinyglobbyandglob-parentin@doc-kit/corewith a small#utils/glob.mjson Node.js's built-infs.globSync(stable since 22.17 and 24.0; doc-kit targets Node.js 24, per.nvmrc):findFiles(patterns, { cwd, ignore })returns the same POSIX,cwd-relative paths as tinyglobby, absolute patterns included, and leaves out directories.globParent(pattern)returns the directory before the first glob segment.The
astandast-jsgenerators and two tests use them, andtinyglobbyalso leavespackages/node's devDependencies. Both packages stay in the lockfile, since Vite and our dev tooling use them, so this drops two direct runtime dependencies of@doc-kit/corerather than lockfile entries.Validation
node --run test(754/754),node --run lintandnode --run format:checkare clean, and the frozen-lockfile install passes. The newglob.test.mjscovers matching files without directories,ignore, absolute patterns, aURLascwd, andglobParentfor glob patterns, plain paths and the.//fallbacks.Compared against tinyglobby 0.2.17 and glob-parent 6.0.2 on nodejs/node's own files, both find the same files and the same parent for every pattern:
doc/api/*.md(ignoringquic.md)lib/*.jslib/**/*.js(ignoringlib/internal/**)<checkout>/doc/api/*.mddoc/api/{fs,path}.mdRelated Issues
Came out of the dependency audit in #1178.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.