Repository navigation
Conversation
7 of 8 tasks
Member
|
Amazingg work, does this boost the performance? |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Switch TypeScript type stripping from
swc_ts_fast_stripto the SWC Next crates published on crates.io, pinned to0.4.1. Preserve fixed-width stripping, thetransformSyncAPI, and the existing Node.js REPL helpers.Remove
mode: "transform", theamaro/transformloader, transformation-only options, and their dependencies and tests. Requests for the removed mode now fail instead of falling back to stripping. This is a breaking change, consistent with the removal of transformation support in nodejs/node#61803.The adapters preserve Amaro's diagnostic codes and location fields, while messages and highlighted ranges come from SWC Next. Existing SWC crates remain for REPL helpers and diagnostic formatting.
Validation
Existing local validation of the reviewed changes at
8da62c210:cargo test --manifest-path crates/amaro/Cargo.toml --locked: 18 passed.wasm-pack build crates/amaro --out-name wasm --release --target nodejs -- --locked: passed.npm run build,npm run typecheck, andnpm run ci: passed.npm test: 99 passed, including removed-mode rejection, loader behavior, source positions, and REPL helpers.Draft status
Additional bug analysis of the related swc-next components is currently in progress to look for potential upstream bugs. This PR remains a draft while that analysis continues; the passing tests above do not establish complete compatibility or prove that swc-next is free of bugs.
AI assistance and human review
AI was used to prepare these changes. Human-reviewed by @kdy1.