Skip to content

[stable5.4] fix(migration): keep the option types and order of grid questions on import - #3885

Merged
Chartman123 merged 1 commit into
stable5.4from
backport/3884/stable5.4
Nov 11, 2026
Merged

Chartman123 merged 1 commit into
stable5.4from
backport/3884/stable5.4

Conversation

@backportbot

@backportbot backportbot Bot commented Nov 11, 2026

Copy link
Copy Markdown

Backport of PR #3884

…import

The export dropped the option ids and the import set neither the order
nor the type of an option. Imported grid questions turned their rows and
columns into plain choices in random order, and the answers to grid and
ranking questions kept the ids of the exported options, so they pointed
to no option.

The export keeps the option ids, and the import restores the order and
type of each option and replaces the option ids in the answers to grid
and ranking questions with the ids of the imported options. Archives
from earlier versions import as before.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@backportbot backportbot Bot added bug Something isn't working 3. to review Waiting for reviews labels Nov 11, 2026
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/FormsMigrator.php 96.29% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit f457469 into stable5.4 Nov 11, 2026
50 checks passed
@Chartman123
Chartman123 deleted the backport/3884/stable5.4 branch November 11, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants