Repository navigation
fix(submission): keep the text of an answer "Other" as typed - #3882
Merged
Merged
Conversation
Storing an answer "Other" removes only the prefix system-other-answer: at its start, as the submit view does, instead of every occurrence of it in the text. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Chartman123
approved these changes
Nov 11, 2026
Collaborator
|
/backport to stable5.4 |
Chartman123
enabled auto-merge
November 11, 2026 10:29
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storing an answer "Other" removed every occurrence of the prefix
system-other-answer:from the text the respondent typed, not only the leading one, so a text that contains the prefix was stored shortened. The server now removes only the leading prefix, as the submit view already does when it shows the answer.Found while reviewing #3833, which changes the line above this one, so whichever of the two lands second needs a small rebase.
Tests
ApiControllerTest::testNewSubmission_answersstores an answer "Other" whose text contains the prefix.IUserFoldererrorsmainalso has on the test instance; php-cs-fixer is clean.🤖 AI (if applicable)