Skip to content

[stable5.4] fix(editor): save all extra settings changed in quick succession #3880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chartman123 merged 1 commit into from
Nov 11, 2026
Merged

[stable5.4] fix(editor): save all extra settings changed in quick succession #3880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions src/composables/useQuestion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,14 +209,24 @@ export function useQuestion(props: QuestionPropsLike, options: UseQuestionOption
saveQuestionProperty('isRequired', isRequiredValue)
}, INPUT_DEBOUNCE_MS)

const onExtraSettingsChange = debounce(function (
newSettings: Record<string, unknown>,
) {
const newExtraSettings = { ...props.extraSettings, ...newSettings }
let pendingExtraSettings: Record<string, unknown> = {}
const saveExtraSettings = debounce(function () {
const newExtraSettings = { ...props.extraSettings, ...pendingExtraSettings }
pendingExtraSettings = {}
options.emit('update:extraSettings', newExtraSettings)
saveQuestionProperty('extraSettings', newExtraSettings)
}, INPUT_DEBOUNCE_MS)

/**
* Save changed extra settings; changes within the debounce time are saved together
*
* @param newSettings the changed extra settings
*/
const onExtraSettingsChange = (newSettings: Record<string, unknown>): void => {
pendingExtraSettings = { ...pendingExtraSettings, ...newSettings }
saveExtraSettings()
}

const onNameChange = debounce(function (name: string) {
options.emit('update:name', name)
saveQuestionProperty('name', name)
Expand Down
Loading