Repository navigation
[stable5.4] fix(submission): do not require hidden questions, reject booleans on linear scales - #3877
Merged
Merged
Conversation
The submit view hides questions without a title, choice, dropdown and ranking questions without options, and grid questions without rows or columns. The server still required an answer to such a question when it was marked as required, so every submission failed with "Question "" is required." and respondents could not fix it. Skip the required check for these questions, using the same rules as the submit view. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
A linear scale accepted the answer true as the value 1, as the check cast it to the string "1". A list was cast to "Array" with a warning before it was rejected. Both are now rejected as not being a value of the scale. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
backportbot
Bot
added
bug
AndyScherzinger
approved these changes
Nov 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Chartman123
enabled auto-merge
November 11, 2026 09:22
Chartman123
disabled auto-merge
November 11, 2026 10:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #3870