Repository navigation
[stable5.4] fix(a11y): keep the focus and list structure in the editor - #3875
Merged
Merged
Conversation
Adding a question moves the focus to the title of the new question. Only checkbox and radio questions handed their root element to useQuestion, so for all other types the focus stayed on the closed menu and fell back to the page. Every question component now hands its root element to useQuestion. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
In the editor, the field of the answer "Other" was a list item after the list of the options, outside of any list. Assistive technologies only expect list items within a list, so it is a plain element now. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Moving a question up keeps the focus on its "Move question up" button. Once the question is the first one, that button is disabled, so the focus fell back to the page and the next Tab started at the top. The same happened with "Move question down" for the last question. Move the focus to the other move button of the question in that case. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
backportbot
Bot
added
bug
AndyScherzinger
approved these changes
Nov 11, 2026
Chartman123
enabled auto-merge
November 11, 2026 09:28
Chartman123
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #3868