Skip to content

fix(migration): skip answers of deleted questions on import - #3872

Merged
AndyScherzinger merged 1 commit into
mainfrom
fix/migration-answers-of-deleted-questions
Nov 11, 2026
Merged

AndyScherzinger merged 1 commit into
mainfrom
fix/migration-answers-of-deleted-questions

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Split out of #3833, so it can be merged and backported on its own. The commits are unchanged and drop out of #3833 once this is merged.

  • Importing a user's forms skips the answers of deleted questions instead of failing and stopping the import of the remaining forms.

Tests

  • FormsMigratorTest passes (12 tests).

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Deleted questions are not exported, their answers are. Importing such an
answer failed, as no imported question belongs to it, and stopped the
import of the remaining forms.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added bug Something isn't working 3. to review Waiting for reviews labels Nov 11, 2026
@AndyScherzinger AndyScherzinger self-assigned this Nov 11, 2026
@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chartman123

Copy link
Copy Markdown
Collaborator

/backport to stable5.4

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Nov 11, 2026
@AndyScherzinger
AndyScherzinger merged commit 4b4ea22 into main Nov 11, 2026
51 checks passed
@AndyScherzinger
AndyScherzinger deleted the fix/migration-answers-of-deleted-questions branch November 11, 2026 09:07
@backportbot backportbot Bot removed the backport-request Pending backport by the backport-bot label Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants