Repository navigation
fix(api): treat deleted questions as not found when deleting or copying them - #3871
Merged
Merged
Conversation
…ng them A deleted question keeps its row with order 0. Deleting it again moved every question after order 0 one position up, so the first question of the form got order 0 and was deleted as well. Copying it failed when the form had no other questions, and otherwise brought the deleted question back as a copy. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
added
bug
1 task done
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Chartman123
approved these changes
Nov 11, 2026
Collaborator
|
/backport to stable5.4 |
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #3833, so it can be merged and backported on its own. The commits are unchanged and drop out of #3833 once this is merged.
Tests
ApiControllerTestcovers both cases.🤖 AI (if applicable)