Skip to content

Conditional questions: branches on file upload - #3836

Closed
AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-3-date-timefrom
feat/conditional-questions-4-file
Closed

Conditional questions: branches on file upload#3836
AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-3-date-timefrom
feat/conditional-questions-4-file

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part 4 of the conditional questions stack from #3123 (by Micke Nordin, with fixes by TimedIn and the review fixes). Based on #3835; the "Files changed" tab shows only this part.

Stack

  1. Conditional questions: go to a question based on the answer #3833 Conditional questions: base with radio and dropdown questions
  2. Conditional questions: go to a question after checkbox questions #3834 Conditional questions: branches on checkboxes
  3. Conditional questions: go to a question after date and time questions #3835 Conditional questions: branches on date and time
  4. Conditional questions: branches on file upload #3836 Conditional questions: branches on file upload ← this PR
  5. Conditional questions: go to a question based on the value of a linear scale #3837 Conditional questions: branches on linear scale and color
  6. Conditional questions: branches on short and long text #3838 Conditional questions: branches on short and long text

This PR

A file question shows a branch depending on whether a file was uploaded, so a branch can also stand for "no file uploaded".

  • an unanswered file question opens its "no file uploaded" branch, other question types open nothing until answered;
  • uploads are checked and stored like those of any file question (upload token of the same form);
  • docs and tests.

Tests

  • Unit tests: 641, all passing except the 15 IUserFolder errors main has as well.
  • php-cs-fixer, psalm, eslint, vue-tsc (no new errors) and the build are clean.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AndyScherzinger AndyScherzinger added this to the 5.5 milestone Nov 4, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request 3. to review Waiting for reviews labels Nov 4, 2026
This was referenced Nov 4, 2026
Draft
Draft
Draft
Draft
Closed
Closed
@codecov

codecov Bot commented Nov 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 85.71% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from a9f1f27 to f0235a8 Compare November 4, 2026 14:07
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from 21c5283 to fe30885 Compare November 4, 2026 14:20
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch 2 times, most recently from a5dc275 to 62a5b50 Compare November 4, 2026 16:51
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from f1898c5 to b287cc5 Compare November 5, 2026 11:10
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch 2 times, most recently from 7262451 to 39cc9b5 Compare November 7, 2026 15:29
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from b287cc5 to 9214258 Compare November 7, 2026 15:29
@AndyScherzinger AndyScherzinger changed the title Conditional questions: file upload as trigger Conditional questions: branches on file upload Nov 7, 2026
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from 39cc9b5 to ea3004c Compare November 7, 2026 15:41
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from 2e47a17 to b8de1b0 Compare November 8, 2026 18:03
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from ea3004c to 50ca16b Compare November 8, 2026 18:03
@AndyScherzinger
feat(conditional): allow branches on file questions
c5f88a4 
A file question opens a branch depending on whether a file was
uploaded, so a branch can also stand for "no file uploaded". Uploads
of the question are checked and stored like those of any file
question.

The code comes from the original pull request #3123 by Micke Nordin
and TimedIn, with the review fixes applied.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-3-date-time branch from 50ca16b to e494c4f Compare November 9, 2026 11:40
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from b8de1b0 to c5f88a4 Compare November 9, 2026 11:40
@AndyScherzinger
AndyScherzinger marked this pull request as draft November 9, 2026 21:38
@AndyScherzinger AndyScherzinger removed the 3. to review Waiting for reviews label Nov 9, 2026
@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Nov 9, 2026
@AndyScherzinger

AndyScherzinger commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

Closing this one: follow-up questions triggered by a file upload are dropped from the stack, see #3833 (comment) for the reasons. File questions still work as follow-up questions.

The branch feat/conditional-questions-4-file stays for reference, in case the trigger is asked for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing Work in progress enhancement New feature or request

Projects

None yet

Milestone

5.5

Development

Successfully merging this pull request may close these issues.

1 participant

@AndyScherzinger