[130s]

Description

Fixes #1128 (in a workaround fashion)

Solution (Option 1)

This PR implements Option 1 in #1128: pins moveit_task_constructor to tag ros2-0.1.8 that was made right before the change that causes #1128, specifically for the jazzy-release matrix job.

Summary by CodeRabbit

• Chores
  • Updated CI configuration to check out a specific version of moveit_task_constructor for each image.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow adds a matrix-level command to pull upstream sources and check out moveit_task_constructor at ros2-0.1.8. The existing job-level upstream pull command remains.

Changes: CI upstream checkout pin

Layer / File(s)	Summary
Matrix-level upstream checkout .github/workflows/ci.yaml	The CI matrix adds a command to pull upstream sources and check out moveit_task_constructor at ros2-0.1.8. The job-level upstream pull command remains.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: rhaschke

Merge Risk: Minimal · up to 3ac2b

This change only affects CI for the jazzy-release job by pinning an upstream dependency. It does not change product behavior. No CI validation result was supplied, but no concrete merge-blocking risk was identified.

Pre-merge checks: 4

Check name	Status	Explanation
Linked Issues check		Issue #1128 asks for a CI fix for the jazzy-release job. Its Option 1 pins moveit_task_constructor to tag ros2-0.1.8 for that job only, through AFTER_SETUP_UPSTREAM_WORKSPACE, without a duplicate .git…
Out of Scope Changes check		The whole-PR diff against the merge base changes one workflow file, .github/workflows/ci.yaml, by about one added line in the jazzy-release matrix entry, per the supplied change summary. The change di…
Title check		The title states that the change pins the moveit_task_constructor version for the jazzy-release CI job to avoid a build failure. The raw summary confirms the CI matrix now sets AFTER_SETUP_UPSTREAM_WO…
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.

Full details: Linked Issues check

Explanation

Issue #1128 asks for a CI fix for the jazzy-release job. Its Option 1 pins moveit_task_constructor to tag ros2-0.1.8 for that job only, through AFTER_SETUP_UPSTREAM_WORKSPACE, without a duplicate .github/upstream.repos. At head, .github/workflows/ci.yaml adds this pin on the jazzy-release matrix entry: AFTER_SETUP_UPSTREAM_WORKSPACE: vcs pull $BASEDIR/upstream_ws/src && git -C $BASEDIR/upstream_ws/src/moveit_task_constructor checkout ros2-0.1.8. The job-level default (vcs pull only) remains for the other images. The matrix env is passed to the industrial_ci step, so the override applies to jazzy-release. Options 2 to 4 in #1128 are alternatives, not requirements. Limits: the repository check does not show the contents of the external tag ros2-0.1.8, so it does not confirm that this tag builds with pybind11 2.11.1. The PR description reports no CI run. The compliance claim rests on the configured change, not on a successful jazzy-release run.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against the merge base changes one workflow file, .github/workflows/ci.yaml, by about one added line in the jazzy-release matrix entry, per the supplied change summary. The change directly implements Option 1 of #1128. It does not alter other images, upstream.repos, or unrelated CI steps. The attempted git diff tool call returned no text because changed blobs were unavailable. The file view at head confirms the content. No out-of-scope change was found.

Full details: Title check

Explanation

The title states that the change pins the moveit_task_constructor version for the jazzy-release CI job to avoid a build failure. The raw summary confirms the CI matrix now sets AFTER_SETUP_UPSTREAM_WORKSPACE to check out moveit_task_constructor at ros2-0.1.8 for each image. The objectives describe the same pin, limited to the jazzy-release job, to avoid the pybind11 3.0 build failure. The title is specific and matches the main change. The title uses a conventional commit prefix, which is acceptable.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: d46075e4-696e-4218-b8b9-aebb87674f29

Commits

Reviewing files that changed from the base of the PR and between 4524ccb and 3ac2b6b.

Files selected for processing: 1

• .github/workflows/ci.yaml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

• Queue this pull request

[130s]

jazzy job indeed is resolved with this (although I found lyrical, rolling started failing #1128).

[130s]

@rhaschke Please review. This is a potential downstream workaround for moveit/moveit_task_constructor#763