Repository navigation
RUBY-4015 Take server_connection_id from the command's own connection - #3129
Merged
comandeo-mongo merged 1 commit intoNov 9, 2026
Merged
Conversation
Command spans read db.mongodb.server_connection_id from the server description. Every new connection's handshake can replace that description, so it holds the id of whichever connection handshook last, not the one the command ran on. Use the connection's own description, as command monitoring does.
jamis
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command spans took db.mongodb.server_connection_id from the server description. Every new connection's handshake can replace that description, so it holds the id of whichever connection connected last, not the one that ran the command. With two pooled connections one of them reported the other's id. This uses the connection's own description, as command monitoring already does.
Jira: https://jira.mongodb.org/browse/RUBY-4015