Skip to content

fix: broken modified at time cause crash - #8271

Merged
mergify[bot] merged 2 commits into
mainfrom
cal/fix-mtime-issue
Nov 10, 2026
Merged

mergify[bot] merged 2 commits into
mainfrom
cal/fix-mtime-issue

Conversation

@IMB11

@IMB11 IMB11 commented Nov 9, 2026

Copy link
Copy Markdown
Member

No description provided.

@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The change affects several file workflows in the app library.

The PR appears safe to merge, with a non-blocking concern about stale hashes for files with pre-1970 timestamps.

Summary

Changes file_modified_at_ns to return zero for modification times before 1970 instead of returning an error.

  • File timestamps before UNIX_EPOCH now become zero.

Reviews (1) · Last reviewed commit: "fix: broken modified at time cause crash" · Reviewed by Greptile

Comment thread packages/app-lib/src/state/cache.rs Resolved
@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Queue requested — the merge queue status continues in this comment ↓.

@IMB11

IMB11 commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

1 similar comment
@IMB11

IMB11 commented Nov 10, 2026

Copy link
Copy Markdown
Member Author

@Mergifyio queue

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

✅ Merged into main as 9c9d812 at 15:44 UTC

1 min in the queue, with no time running CI.

So far

2 merge conditions met
  • github-review-approved · required by GitHub branch protection
  • any of · required by GitHub branch protection:
    • check-skipped = Lint and Test
    • check-neutral = Lint and Test
    • check-success = Lint and Test

Times in UTC · dashboard · how the merge queue works

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown

queue

☑️ Command queue ignored because it is already running from a previous command.

@mergify mergify Bot added the queued label Nov 10, 2026
@mergify
mergify Bot merged commit 9c9d812 into main Nov 10, 2026
7 checks passed
@mergify
mergify Bot deleted the cal/fix-mtime-issue branch November 10, 2026 15:44
@mergify mergify Bot removed the queued label Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants